Fix GlassFish static shell bootstrap setup #25751
Conversation
OndroMih
commented
Oct 25, 2025
OndroMih
commented
- Was missing several JARs in the JAR classpath after they were relocated earlier
- Behaved as DAS. Now behaves as Embedded
- Added static shell as another target for Embedded tests
* Was missing several JARs in the JAR classpath after they were relocated earlier * Behaved as DAS. Now behaves as Embedded * Added static shell as another target for Embedded tests
|
There are tests failing related to Embedded GF in normal server. Looks like the Embedded runtime is also used in server in some obscure scenario. I will need to find a better way to detect when @dmatej, do know know under which situation is |
| arguments.add(Arguments.of("glassfish-embedded-all.jar")); | ||
| if (!GfEmbeddedUtils.isDebugEnabled()) { | ||
| arguments.add(Arguments.of("glassfish-embedded-web.jar")); | ||
| arguments.add(Arguments.of("glassfishXX/glassfish/lib/embedded/glassfish-embedded-static-shell.jar" |
There was a problem hiding this comment.
The root directory can have any name. Subdirectories should not be changed, so we can rely on glassfish, but its parent doesn't have any convention, people do rename it.
|
Static is not really embedded, it is rather a bastard made just for few TCK tests if I remember well. It should not be used at all, and maybe for those TCKs we should enforce real embedded jar instead and kill this monster. It is a monster because it uses "random" jar files and files spread over standard Eclipse GlassFish server. |
|
Hi, @dmatej , I only care about static shell because our Docker image allows using it as runnable embedded GlassFish, using the same image as for server. We should really have a separate docker image for Embedded GlassFish, then we don't need static shell at all. So, I'll move this PR on hold (draft) just as a reminder and we should create an Embedded GlassFish docker image. I'll close this PR afterwards. |
|
Aha, I was wondering what was the motivation behind this, I do remember we were talking about it. |
2 participants
